[#160] Support of ExtendWith annotation #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello-zoka
added
new feature
Collaborator
stephanlukasczyk
left a comment
stephanlukasczyk
left a comment
There was a problem hiding this comment.
Could you please provide a clarification on my question in the JavaDisplayUtils and KotlinDisplayUtils? I am not sure whether I misunderstand it or whether there is a change missing.
src/main/kotlin/org/jetbrains/research/testspark/display/utils/java/JavaDisplayUtils.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/research/testspark/display/utils/kotlin/KotlinDisplayUtils.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
Yes, changes were missed. Fixed. |
stephanlukasczyk
approved these changes
Apr 11, 2025
…ity of storing 2 annotation types
stephanlukasczyk
force-pushed
the
izaitsev/bugs/160-extend-with-annotation-fix
branch
from
1580739 to
1b97ec4
Compare
stephanlukasczyk
deleted the
izaitsev/bugs/160-extend-with-annotation-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
Previously, both
ExtendWithandRunWithannotations were replaced withRunWithones since it is available in both JUnit versions. This fix makes any annotation used in JUnit 4 be replaced withRunWith, while for JUnit 5 replaces it withExtendWith(which is a superset of runWith). Also introduces more logical variable naming.Why is a merge request needed
These changes have the potential to lower the amount of compilation errors for JUnit 5 tests, in case of using unique for
ExtenWithannotation APIs.Other notes
Closes #160